Messages in this thread Patch in this message |  | | Date | Mon, 27 Nov 2000 09:12:28 +0100 | From | Luca Berra <> | Subject | Re: [BUG] 2.4.0-test11-ac3 breaks raid autodetect (was Re: [BUG] raid5 link error? (was [PATCH] raid5 fix after xor.c cleanup)) |
| |
On Mon, Nov 27, 2000 at 01:18:52PM +1100, Neil Brown wrote: > > Sorry to tell you that I just tried linux-2.4.0-test11-ac3 (which has this > > patch) and I couldn't boot because the kernel detects the raid1 devices > > but kicks the shortly after. I had to back out this code. > > Thanks for this.... > > I have looked more deeply, and discovered the error of my ways. also test11-ac4 contains the following patch which is broken and should be reversed! (if xor.o is built as a module it will export the symbol calibrate_xor_block_R??????? and require calibrate_xor_block ?!?) anyway the only piece of code that uses calibrate_xor_block is drivers/md/xor.c itself, so why export?
Regards, L.
--- drivers/md/xor.c Sun Nov 26 21:35:14 2000 +++ drivers/md/xor.c.ac4.foo Sun Nov 26 21:43:52 2000 @@ -98,7 +98,7 @@ speed / 1000, speed % 1000); }
-static int +int calibrate_xor_block(void) { void *b1, *b2; @@ -139,5 +139,6 @@ }
MD_EXPORT_SYMBOL(xor_block); +MD_EXPORT_SYMBOL(calibrate_xor_block);
module_init(calibrate_xor_block);
-- Luca Berra -- bluca@comedia.it Communication Media & Services S.r.l. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org Please read the FAQ at http://www.tux.org/lkml/
|  |