Messages in this thread |  | | Date | Mon, 27 Nov 2000 11:49:50 +0100 | From | Christoph Hellwig <> | Subject | Re: [KBUILD] Re: [BUG] 2.4.0-test11-ac3 breaks raid autodetect (was Re: [BUG] raid5 link error? (was [PATCH] raid5 fix after xor.c cleanup)) |
| |
On Mon, Nov 27, 2000 at 01:18:52PM +1100, Neil Brown wrote: > Thanks for this.... > > I have looked more deeply, and discovered the error of my ways. > As the Makefiles now stand, all export-objs (OX_OBJS) get linked > before non-export-objs (O_OBJS) in the same directory, independantly > of any ordering imposed within the Makefile.
Yes.
> This caused md.o to get linked before raid?.o. > Due to carelessness on my part I didn't notice this happening when I > was testing. > > The following patch fixes it. I hope the change to Rules.make is > acceptable - I have CCed to linux-kbuild incase anyone there has an > issue with it.
I don't think so. Look at drivers/usb/Makefile for an other (cleaner) solution to solve this. I don't think it is a good idea to solve the same problem with two different hacks...
Christoph
-- Always remember that you are unique. Just like everyone else. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org Please read the FAQ at http://www.tux.org/lkml/
|  |