Messages in this thread Patch in this message |  | | Date | Mon, 27 Nov 2000 16:02:13 -0600 | Subject | Re: silly [< >] and other excess | From | Peter Samuelson <> |
| |
[Albert D. Cahalan] > > Somebody else posted a reasonable hack for the [<>] problem. His > > proposal involved letting multiple values share the same markers, > > something like this:
[Russell King] > Yep, now that is one idea I like!
Me too. (: Keith posed two objections:
1. The >] could get word-wrapped so that it doesn't appear on the same line as the [<. I *do not* see what makes this hard to parse reliably.
2. Someone (i.e. kernel debugger) could insert extra text. Well, same culprits can mangle oopsen already -- see klogd. These evil tools, whichever ones they may be, should learn to use /* */ or something. That way it is relatively easy to ignore their output.
Peter
PS. Should we be using KERN_* here?
--- arch/i386/kernel/traps.c.orig Mon Nov 13 01:44:02 2000 +++ arch/i386/kernel/traps.c Thu Nov 23 10:10:06 2000 @@ -126,7 +126,6 @@ printk("%08lx ", *stack++); } - printk("\nCall Trace: "); stack = esp; i = 1; module_start = VMALLOC_START; @@ -144,12 +143,17 @@ if (((addr >= (unsigned long) &_stext) && (addr <= (unsigned long) &_etext)) || ((addr >= module_start) && (addr <= module_end))) { - if (i && ((i % 8) == 0)) - printk("\n "); - printk("[<%08lx>] ", addr); + if (i==1) + printk("\nCall Trace: [<"); + else if ((i % 8)==0) + printk(">]\n [<"); + else + printk(" "); + printk("%08lx", addr); i++; } } + printk(">]\n"); } static void show_registers(struct pt_regs *regs) - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org Please read the FAQ at http://www.tux.org/lkml/
|  |