Messages in this thread |  | | Date | Wed, 22 Nov 2000 23:40:47 -0600 | Subject | Re: [NEW DRIVER] firestream | From | Peter Samuelson <> |
| |
[Patrick van de Lageweg] > diff -u -r --new-file linux-2.4.0-test11.clean/drivers/atm/firestream.c linux-2.4.0-test11.fs50+atmrefcount/drivers/atm/firestream.c
Since you are submitting in the form of a source patch, you ought to include the relevent bits of
drivers/atm/Makefile drivers/atm/Config.in Documentation/Configure.help
> +int loopback = 0; > +int fs_debug = 0; > +struct fs_dev *fs_boards = NULL;
Aside from the 'static' issue already mentioned, these should be left uninitialized. ('gcc -fassume-bss-zero' would be nice, but then again in userspace it rarely matters.)
Peter - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org Please read the FAQ at http://www.tux.org/lkml/
|  |