Messages in this thread Patch in this message |  | | Date | Thu, 23 Nov 2000 10:14:31 -0600 | Subject | [PATCH] silly [< >] and other excess | From | Peter Samuelson <> |
| |
[Alan Cox] > > Thats because too many things get put on a line then. > > And because we do [<foo>] [<bar>] not [<foo>][<bar>] ?
[Andries Brouwer] > In the good old times we had foo bar for a total of 8*(8+1) = 72 > positions. Now we have [<foo>] [<bar>] which takes 8*(8+1+4) = 104
I've got it! Put multiple addresses within one set of [< >]. ksymoops and klogd will require a small adjustment, of course.
The following show_stack() is 8 addrs per line, 79 columns. Comments?
Peter
--- arch/i386/kernel/traps.c.orig Mon Nov 13 01:44:02 2000 +++ arch/i386/kernel/traps.c Thu Nov 23 10:10:06 2000 @@ -126,7 +126,6 @@ printk("%08lx ", *stack++); } - printk("\nCall Trace: "); stack = esp; i = 1; module_start = VMALLOC_START; @@ -144,12 +143,17 @@ if (((addr >= (unsigned long) &_stext) && (addr <= (unsigned long) &_etext)) || ((addr >= module_start) && (addr <= module_end))) { - if (i && ((i % 8) == 0)) - printk("\n "); - printk("[<%08lx>] ", addr); + if (i==1) + printk("\nCall Trace: [<"); + else if ((i % 8)==0) + printk(">]\n [<"); + else + printk(" "); + printk("%08lx", addr); i++; } } + printk(">]\n"); } static void show_registers(struct pt_regs *regs) - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org Please read the FAQ at http://www.tux.org/lkml/
|  |