Messages in this thread |  | | Date | Wed, 22 Nov 2000 23:18:54 +0100 | From | Andi Kleen <> | Subject | Re: Patch(?): pci_device_id tables for linux-2.4.0-test11/drivers/block |
| |
On Wed, Nov 22, 2000 at 05:14:38PM -0500, Jeff Garzik wrote: > *This* is the over-engineering attitude I was talking about. The only > reason why you are preferring named initializers is because > pci_device_id MIGHT be changed. And if it is changed, it makes the > changeover just tad easier. For that, you ugly up the code and make it > more difficult to maintain.
The other reason is that it makes self documenting code -- no need to look up the structure definition to make sense out of the code.
-Andi (who thinks easily readable code is good)
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org Please read the FAQ at http://www.tux.org/lkml/
|  |