lkml.org 
[lkml]   [2000]   [Nov]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] Large "clipped" IDE disk support for 2.4 when using old BIOS
Date
From

> Both disks claim support for the Host Protected Area feature set.
> No doubt early disks had firmware flaws.

So it's yet another "borken hardware"... Is there anything like
SCSI "blacklist" for IDE driver? Then it could be handled easily
by registering the drive there and check that out before autodetection.

> - The routine idedisk_supports_host_protected_area()
> should look at bit 10 of command_set_1, but it does a "& 0x0a".

Oh, no. Thanks for catching that. It should obviously be 0x0400.

# I guess it got converted in a way like this: 10th bit -> 10 -> 0x0a. Ugh.

> - The assignment "hd_cap = hd_max;" is one off:

Now that explains one missing sector reported previously. Yes,
ATA spec says that the command returns "maximum address", not
number of sectors.

I'll make a fix and resend a patch - or since the fix is so
simple, I guess Andre can just add these fixes to IDE driver directly.

--
Taisuke Yamada <tai@imasy.or.jp>
PGP fingerprint = 6B 57 1B ED 65 4C 7D AE 57 1B 49 A7 F7 C8 23 46
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 12:47    [W:0.110 / U:6.420 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site