Messages in this thread |  | | Date | Tue, 21 Nov 2000 00:13:14 +0100 | From | Abramo Bagnara <> | Subject | Re: easy-to-fix bug in /dev/null driver |
| |
Michal Jaegermann wrote: > > On Tue, Nov 21, 2000 at 12:53:04AM +1030, Alan Kennington wrote: > > > > I still think that write_null() should be rewritten as: > > > > =================================================== > > static ssize_t write_null(struct file * file, const char * buf, > > size_t count, loff_t *ppos) > > { > > return (count <= 2147483647) ? count : 2147483647; > > } > > =================================================== > > > > This would fix the problem without introducing any new errors. > > (Unless someone change the definitions of ssize_t and size_t!!) > > Someone already did. Or, more precisely, there are platforms where > values used in 'return' above are bogus. > > Shifting 1 up by sizeof(ssize_t) * 8 - 1 and subtracting one from > the result, in order to derive the maximal allowable value, might work. > I do not think that we have anything with non-8 bit bytes yet. >
I think it's time to provide SIZE_MAX and SSIZE_MAX along with size_t/ssize_t typedefs.
-- Abramo Bagnara mailto:abramo@alsa-project.org
Opera Unica Phone: +39.546.656023 Via Emilia Interna, 140 48014 Castel Bolognese (RA) - Italy
ALSA project is http://www.alsa-project.org sponsored by SuSE Linux http://www.suse.com
It sounds good! - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org Please read the FAQ at http://www.tux.org/lkml/
|  |