lkml.org 
[lkml]   [2000]   [Nov]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH] megaraid driver update for 2.4.0-test10
    From
    Date
    >>>>> "dalecki" == dalecki  <dalecki@evision-ventures.com> writes:

    A few questions after scanning through your patch, it's likely I
    missed something but I am kind acurious.

    dalecki> The attached patch does the following: 1. Merge the most
    dalecki> current version (aka: 1.08) of the MegaRAID driver from AMI
    dalecki> in to the most current kernel (2.4.0-test10 and friends).

    Hmmm I don't get it why you changed the return type of the
    readl/writel macros to return unsigned long rather than u32 - is there
    a reason for this other than to get sign extension?

    dalecki> 3. Fix the virt_to_phys mapping for scatter-gather transfers
    dalecki> as well as some other minor tidups here and there.

    What are you trying to achieve there? You run virt_to_phys() on a user
    space address as far as I can read and stick it into something
    labelled xferaddr? Normally you should never need the physical address
    in a device driver unless you want to play with page table settings or
    the like. If the address is to be handed to a DMA engine you should
    never take the physical address, but rather use virt_to_bus() or even
    better use the new 2.3+ PCI DMA API (pci_map_single()).

    Jes
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2005-03-22 12:47    [W:3.213 / U:0.936 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site