Messages in this thread |  | | Date | Sat, 18 Nov 2000 17:08:17 -0500 (EST) | From | Alexander Viro <> | Subject | Re: [PATCH] ext2 largefile fixes + [f]truncate() error value fix |
| |
On Sat, 18 Nov 2000, Andreas Dilger wrote:
> Alexander Viro writes: > > * #include <linux/ext2_fs.h> removed from ksyms.c. It is not > > needed there (hardly a surprise, since ext2 can be modular itself and > > it doesn't export anything). Ditto for <linux/minix_fs.h> > > * #include <linux/ext2_fs.h> removed from fs/nfsd/vfs.c > > I've been trying to get these fixed a couple of times myself.... > > > static int ext2_get_block(struct inode *inode, long iblock, struct buffer_head *bh_result, int create) > > Would you be willing to accept a patch for this function which reorganizes
I'm neither Ted nor Stephen, so...
> it to be sane - i.e. exit at the bottom and not the middle, no jumps into > the middle of "if" blocks, etc?
I certainly have nothing against it. If it doesn't grow the thing too much and doesn't introduce tons of gotos on the main path... no objections from me.
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org Please read the FAQ at http://www.tux.org/lkml/
|  |