Messages in this thread |  | | From | Andreas Dilger <> | Subject | Re: [PATCH] ext2 largefile fixes + [f]truncate() error value fix | Date | Sat, 18 Nov 2000 08:46:57 -0700 (MST) |
| |
Alexander Viro writes: > * #include <linux/ext2_fs.h> removed from ksyms.c. It is not > needed there (hardly a surprise, since ext2 can be modular itself and > it doesn't export anything). Ditto for <linux/minix_fs.h> > * #include <linux/ext2_fs.h> removed from fs/nfsd/vfs.c
I've been trying to get these fixed a couple of times myself....
> static int ext2_get_block(struct inode *inode, long iblock, struct buffer_head *bh_result, int create)
Would you be willing to accept a patch for this function which reorganizes it to be sane - i.e. exit at the bottom and not the middle, no jumps into the middle of "if" blocks, etc?
Cheers, Andreas -- Andreas Dilger \ "If a man ate a pound of pasta and a pound of antipasto, \ would they cancel out, leaving him still hungry?" http://www-mddsp.enel.ucalgary.ca/People/adilger/ -- Dogbert - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org Please read the FAQ at http://www.tux.org/lkml/
|  |