Messages in this thread |  | | Subject | Re: RFC: "SubmittingPatches" text | Date | Sat, 18 Nov 2000 11:16:15 +0100 (MET) | From | (Rogier Wolff) |
| |
Alan Cox wrote: > Maybe also note that maintainers of given modules are much more likely to > give feedback than Linus, also the [PATCH]: convention
Question:
Should a submitter CC Linus or linux-kernel on the patch before having gotten approval from a maintainer?
I'd say DO CC Linux-kernel, don't CC Linus.
Otherwise Linus may get a patch that he doesn't know if it violates the essential ideas behind some vague driver. And the message with it could say: "As suggested by <driver-author>".
If Linux-kernel and the driver-author don't have any objections to the patch, send it to Linus and the driver author, keeping Linux-kernel out of the loop, this time with a note:
"Linus: Reviewed by <driver-author> and Linux-kernel, please apply".
Note that Linus will not have read the previous discussion, so some of the ideas of the patch may have to be repeated....
This is the way I'd like things to work. Feel free to disagree, and try to convince me why it's wrong....
Roger.
-- ** R.E.Wolff@BitWizard.nl ** http://www.BitWizard.nl/ ** +31-15-2137555 ** *-- BitWizard writes Linux device drivers for any device you may have! --* * Common sense is the collection of * ****** prejudices acquired by age eighteen. -- Albert Einstein ******** - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org Please read the FAQ at http://www.tux.org/lkml/
|  |