Messages in this thread |  | | Date | Wed, 15 Nov 2000 15:40:13 -0500 | From | Jeff Garzik <> | Subject | Re: CONFIG_USB_HOTPLUG (was Patch(?): linux-2.4.0-test11-pre4/drivers/sound/yss225.c compile failure) |
| |
"Adam J. Richter" wrote: > You were right: the > __devinitdata being used in the USB drivers will probably crash the > kernel if CONFIG_HOTPLUG is not defined and the USB code attempts to > recover from an error by faking disconnect/reconnect. [...] > Until there is __usbdev{init,exit}{,data}, the incorrect > __devinitdata qualifiers should be removed from the USB device > drivers (but not from the host controller drivers, which are PCI drivers).
If a user hotplugs a device into a kernel which does not support CONFIG_HOTPLUG, they are shooting themselves in the foot.
I don't see that __devinitdata should be removed.
*plonk*
-- Jeff Garzik | Building 1024 | The chief enemy of creativity is "good" sense MandrakeSoft | -- Picasso - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org Please read the FAQ at http://www.tux.org/lkml/
|  |