Messages in this thread |  | | From | Russell King <> | Subject | Re: [PATCH] pcmcia event thread. (fwd) | Date | Wed, 15 Nov 2000 00:01:15 +0000 (GMT) |
| |
David Woodhouse writes: > If we don't specify CLONE_FS | CLONE_FILES | CLONE_SIGHAND then new ones > get allocated just for us to free them again immediately. If we clone them, > then we just increase and decrease the use counts of the parent's ones. The > latter is slightly more efficient, and I don't think it really matters. If > you really care, that can be changed. I've dropped CLONE_SIGHAND because > daemonize() doesn't free that, but left CLONE_FS and CLONE_FILES.
Small suggestion - when your thread is created, make sure that all /proc accesses to stuff relating to this thread doesn't cause the kernel to panic.
I used to create some processes with '0' as the third arg until Debian's start-stop-daemon script started killing peoples machines with a kernel oops. Now I always use CLONE_FS | CLONE_FILES | CLONE_SIGHAND as per fs/buffer.c (which I used as the reference for creating kernel threads). _____ |_____| ------------------------------------------------- ---+---+- | | Russell King rmk@arm.linux.org.uk --- --- | | | | http://www.arm.linux.org.uk/personal/aboutme.html / / | | +-+-+ --- -+- / | THE developer of ARM Linux |+| /|\ / | | | --- | +-+-+ ------------------------------------------------- /\\\ | - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org Please read the FAQ at http://www.tux.org/lkml/
|  |