lkml.org 
[lkml]   [2000]   [Nov]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: [PATCH] Re: test11-pre5
    Date
    In article <Pine.LNX.4.21.0011150104250.26856-100000@callisto.yi.org>,
    Dan Aloni <karrde@callisto.yi.org> wrote:
    >On Tue, 14 Nov 2000, Jeff Garzik wrote:
    >
    >> Dan Aloni wrote:
    >> >
    >> > reason: Correct me if I'm wrong, but 3c501.c:init_module() calls
    >> > net_init.c:register_netdev(&dev_3c501), which calls strchr(),
    >> > {and might also,which might} dereference dev_3c501.name.
    >>
    >> There is no dereferencing involved, and therefore no problem.
    >
    >Well, at least I was alertive. Almost a bug fix ;-)
    >Is there a special reason why dev->name is not a pointer?

    It used to be.

    And we used to have an incredible number of bugs with initialization and
    with creating these things dynamically. A lot of Space.c was due to
    horrible hackery with getting the static allocation right for these
    things. Turning it into a plain array got rid of all the hackery, and
    saved memory anyway.

    Linus
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2005-03-22 12:45    [W:0.020 / U:62.020 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site