Messages in this thread |  | | Date | Tue, 14 Nov 2000 16:57:20 -0500 (EST) | From | Alexander Viro <> | Subject | Re: PATCH 2.4.0.11.4: loopback block device fixes |
| |
On Tue, 14 Nov 2000, Jeff Garzik wrote:
> Since I am not a block device expert, I am interested to know if > these fixes look ok, and if they fix the reported loopback deadlocks. > > I added calls to deactive_page and flush_dcache_page, and made sure > that any error returns were propagated back to the caller.
The former looks fine (but I'ld rather cc that to VM folks). The latter is patently useless - for one thing, caller doesn't give a damn for the exact error value, for another it couldn't pass it further even if it wanted. We have no way to tell what went wrong when IO request fails - every async error turns into -EIO.
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org Please read the FAQ at http://www.tux.org/lkml/
|  |