Messages in this thread |  | | Date | Mon, 13 Nov 2000 13:46:30 -0600 | Subject | Re: Modprobe local root exploit | From | Peter Samuelson <> |
| |
[Torsten Duwe] > >>>>> "Francis" == Francis Galiegue <fg@mandrakesoft.com> writes: > > >> + if ((*p & 0xdf) >= 'a' && (*p & 0xdf) <= 'z') continue; > > Francis> Just in case... Some modules have uppercase letters too :) > > That's what the &0xdf is intended for...
It's wrong, then: you've converted to uppercase, not lowercase.
request_module is not a fast path. Do it the obvious, unoptimized way:
if ((*p < 'a' || *p > 'z') && (*p < 'A' || *p > 'Z') && (*p < '0' || *p > '9') && *p != '-' && *p != '_') return -EINVAL;
Peter - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org Please read the FAQ at http://www.tux.org/lkml/
|  |