lkml.org 
[lkml]   [2000]   [Nov]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
Date
SubjectPatch(?): linux-2.4.0-test11-pre4/drivers/sound/yss225.c compile failure



linux-2.4.0-test11-pre4/drivers/sound/yss225.c uses __initdata
but does not include <linux/init.h>, so it could not compile. I have
attached below.

Note that I am a bit uncertain about the correctness of
the __initdata prefix here in the first place. Is yss225 a PCI
device? If so, a kernel that supports PCI hot plugging should
be prepared to support the possibility of a hot pluggable yss225
card being inserted after the module has already been initialized.
Even if no CardBus or CompactPCI version of yss225 hardware exists
yet, it will require less maintenance for PCI drivers to be prepared
for this possibility from the outset (besides, is it possible to have a
hot pluggable PCI bridge card that bridges to a regular PCI bus?).

So, if yss225 is a PCI device, the declaration should use
__devinitdata. On the other hand, if it is ISA only, then __initdata
should be correct.

Adam J. Richter __ ______________ 4880 Stevens Creek Blvd, Suite 104
adam@yggdrasil.com \ / San Jose, California 95129-1034
+1 408 261-6630 | g g d r a s i l United States of America
fax +1 408 261-6631 "Free Software For The Rest Of Us."

--- linux-2.4.0-test11-pre4/drivers/sound/yss225.c Mon Nov 13 13:36:50 2000
+++ linux/drivers/sound/yss225.c Mon Nov 13 09:11:02 2000
@@ -1,3 +1,4 @@
+#include <linux/init.h>
unsigned char page_zero[] __initdata = {
0x01, 0x7c, 0x00, 0x1e, 0x00, 0x00, 0x00, 0x00, 0x00, 0xf5, 0x00,
0x11, 0x00, 0x20, 0x00, 0x32, 0x00, 0x40, 0x00, 0x13, 0x00, 0x00,
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/
\
 
 \ /
  Last update: 2005-03-22 12:45    [W:0.120 / U:7.100 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site