Messages in this thread |  | | From | Christoph Hellwig <> | Subject | Re: [PATCH] kiobuf/rawio fixes for 2.4.0-test10-pre6 | Date | 1 Nov 2000 11:16:28 GMT |
| |
Andrea Arcangeli <andrea@suse.de> wrote: >> + map = follow_page(ptr, datain, &failed); >> + if (failed) { >> + /* >> + * Page got stolen before we could lock it down. >> + * Retry. >> + */ >> spin_unlock(&mm->page_table_lock); >> - dprintk (KERN_ERR "Missing page in map_user_kiobuf\n"); >> - goto out_unlock; >> + goto faultin;
> This is suboptimal (walks the pagetables twice if the page is just mapped). It > should be a follow page first and handle_mm_fault only if follow page failed.
I did only forward-port the fixes from Stpehen's 2.3.99pre2 patchset because no one else seemed to be interested. If someone with more vm-experience (e.g. you) gets interested because of this patch: fine.
Christoph
-- Always remember that you are unique. Just like everyone else. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org Please read the FAQ at http://www.tux.org/lkml/
|  |