lkml.org 
[lkml]   [2000]   [Oct]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] drivers/usb/Config.in
On Mon, Oct 09, 2000 at 05:19:37PM -0700, Matthew Dharm wrote:
>I'm not sure this is correct -- the options that this if conditional
>controls are the Keyboard and Mouse _Boot_Protocol_ support, which is
>separate form the regular HID support -- I believe it's for motherboards
>which can boot from a USB keyboard.
>
>Can somone on the linux-usb-devel mailinglist comment? (I've CC'ed them)
>
>Matt
>
>On Tue, Oct 10, 2000 at 12:14:11AM -0700, James Simmons wrote:
>>
>> This patch fixes a minor config error for drivers/usb/Config.in. When you
>> select USB Human Interface Device (HID) support I assume you should be
>> able to select a USB mouse and/or USB keyboard. With the current Config.in
>> you can't.
>>
>> --- Config.in.orig Tue Oct 10 00:10:06 2000
>> +++ Config.in Tue Oct 10 00:10:27 2000
>> @@ -80,7 +80,7 @@
>> comment ' Input core support is needed for USB HID'
>> else
>> dep_tristate ' USB Human Interface Device (HID) support' CONFIG_USB_HID $CONFIG_USB $CONFIG_INPUT
>> - if [ "$CONFIG_USB_HID" != "y" ]; then
>> + if [ "$CONFIG_USB_HID" = "y" ]; then
>> dep_tristate ' USB HIDBP Keyboard support' CONFIG_USB_KBD $CONFIG_USB $CONFIG_INPUT
>> dep_tristate ' USB HIDBP Mouse support' CONFIG_USB_MOUSE $CONFIG_USB $CONFIG_INPUT
>> fi
Hi,
I'm just a humble user, and not a developer, but this patch looks wrong.
As far as I remember, the whole point to the HIDBP keyboard and HIDBP mouse
drivers was to provide minimal support for USB mice and keyboards, if
someone didn't need everything in the full hid driver. If the full hid driver
is included in the kernel, there is no point to building in the stripped down
drivers as well. The full hid driver supports everything the HIDBP drivers
do, plus a whole lot more. The stripped down drivers for example don't support
any special keys on the keyboard, or any of the fancy mouse protocols like
IMPS/2, or at least, they didn't the last time I looked at them.

-Harold
--
"Life sucks, deal with it!"
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 12:39    [W:0.146 / U:8.072 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site