lkml.org 
[lkml]   [2000]   [Oct]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: 2.4.0-test9: minixfs causing oopsen when out of inodes
Date
Linus Torvalds wrote:
> This, btw, is why Linux returns error numbers as -Exxx instead of using
> "-1" and "errno" - I dislike the latter enormously.

It's not just a matter of disliking it, it's also not reentrant.

> This is also why the VFS layer tends to use ERR_PTR/PTR_ERR/IS_ERR: it
> makes it very easy to pass back error information, and it makes it very
> hard to do it wrong. I suspect both minix and ext2 would be better off
> using that convention instead.
>
> It's not worth changing at this point, but for future reference it would
> probably be much preferable to return the error code instead of the
> horrible "error value through pointer access" method, which is usually
> rather inefficient too.

It would be nice if we could return a struct consisting of the error and
result. I'm not sure if this is allowed in C now or not. It didn't
work when I tried it with gcc: it seems to consider a struct-valued
function to be a void-valued. Odd.

--
Daniel
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 12:45    [W:0.073 / U:0.992 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site