lkml.org 
[lkml]   [2000]   [Oct]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: Bug in "ide-pci.c"

Andre,

BTW, how did your testing of the speed=4 problem with ide-scsi turn
out. We are still seeing the speed=2 problem on 2.4.0-pre9. I cannot
get the drive to burn clean unless the speed setting is cranked down to
speed=2.

Jeff

Andre Hedrick wrote:
>
> On Fri, 6 Oct 2000, Sean Estabrooks wrote:
>
> > ide-pci.c bug:
> >
> > ide_setup_pci_baseregs() may inappropriately report device as not capable of full native PCI:
> >
> > // BUGGY LINE: ============
> > if (pci_read_config_byte(dev, PCI_CLASS_PROG, &progif) || (progif & 5) != 5) {
> > // ========= TWO CONDITIONS USING PROGIF
> > if ((progif & 0xa) != 0xa) {
> > printk("%s: device not capable of full native PCI mode\n", name);
> > return 1;
> > }
> >
> > ...
> >
> > In the first line of code above there is no guarantee that the first condition will be executed
> > before the second. As progif is set to 0 before this block of code, the second test will always
> > be true if it is executed prior to the first.
>
> if () are serial in test.
>
> >
> >
> >
>
> Andre Hedrick
> The Linux ATA/IDE guy
>
> -
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> Please read the FAQ at http://www.tux.org/lkml/
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 12:39    [W:0.534 / U:3.708 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site