lkml.org 
[lkml]   [2000]   [Oct]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
On Thu, 5 Oct 2000, Torben Mathiasen wrote:

> Linus,
>
> This patch includes the following:
>
> Fixes the timer being added twice bug (on tytso's list)
> Convertes driver to new PCI layout
> Adds support for EISA based TLAN adapters.
>
> Patch has been tested for over a month now and is ready for 2.4.
>
> Against final test9.
>

Hi Torben,

Just a tiny comment - maybe you noticed the recent "trend" in moving
zero-initialised data out of data into where it belongs, i.e. bss. Your
patch does a little bit to the contrary, namely bits like:

+static struct net_device *TLan_Eisa_Devices = NULL;

....

+static int tlan_have_pci = 0;
+static int tlan_have_eisa = 0;

etc.

Regards,
Tigran


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 12:39    [W:0.052 / U:17.472 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site