Messages in this thread |  | | Date | Mon, 30 Oct 2000 15:05:43 -0800 (PST) | From | Linus Torvalds <> | Subject | Re: [PATCH] Re: test10-pre7 |
| |
On Mon, 30 Oct 2000, Alexander Viro wrote: > > [ sync_page brokenness ] > > To elaborate: the thing is called if we get a contention on the page lock.
Ok, sync_page() looks like a broken design, but I suspect that for expediency the simplest fix is to just make the NFS sync_page() (re-)check for "mapping == NULL", and let it be at that. Avoid the NULL pointer dereference (very small window already).
We should probably in the long run make "page->buffers" be a more generic thing, and let NFS use it as a wb-info thing, and be done with it. That's obviously not 2.4.x material, though.
Linus
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org Please read the FAQ at http://www.tux.org/lkml/
|  |