lkml.org 
[lkml]   [2000]   [Oct]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: 2.2.18pre13: Small patches
In article <20001002141032.A5193@valinux.com> you wrote:
> Here's a brace of small patches that ought to be OK for 2.2.18.
> adTHANKSvance for consideration

> 3. Trivial patch to fs/vfat/namei.c to avoid a compile-time warning.

> Index: linux/fs/vfat/namei.c
> --- linux/fs/vfat/namei.c:1.2 Fri Sep 1 19:03:16 2000
> +++ linux/fs/vfat/namei.c Thu Sep 28 00:53:55 2000
> @@ -676,7 +676,8 @@
> i += 4;
> } else {
> int llen;
> - nls->char2uni(ip, &llen, op, op+1);
> + nls->char2uni((unsigned char *)ip,
> + &llen, op, op+1);
> op += 2;
> ip += llen;
> i += llen;


Note that this is properly fixed in pre15 by making char2uni's first
argument "const char *" instead of "char *"; casting it as you did only
hides a (currently non existing but potential) bug where an NLS function
might modify the original.....

Greetings,
Arjan van de Ven

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 12:39    [W:0.136 / U:6.400 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site