Messages in this thread |  | | Date | Sat, 28 Oct 2000 23:46:37 -0200 (BRDT) | From | Rik van Riel <> | Subject | Re: tcp_do_sendmsg() allocation still broken ? |
| |
On Sun, 29 Oct 2000, Andi Kleen wrote: > On Sat, Oct 28, 2000 at 07:12:44PM -0200, Marcelo Tosatti wrote: > > > > tcp_do_sendmsg() still allocates using GFP_KERNEL when it can't, it seems: > > tcp_do_sendmsg() should only be called from process context, > because it can sleep for other reasons anyways.
Andi, if sk->allocation is there to be ignored, why don't you remove that element from the structure?
> If someone calls it from interrupt context it needs to be fixed.
Think about nbd. Think about swap-over-network. Think about the reasons why sk->allocation exists.
regards,
Rik -- "What you're running that piece of shit Gnome?!?!" -- Miguel de Icaza, UKUUG 2000
http://www.conectiva.com/ http://www.surriel.com/
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org Please read the FAQ at http://www.tux.org/lkml/
|  |