[lkml]   [2000]   [Oct]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
Patch in this message
SubjectObviously-correct patch to 2.2.17
Hi Alan.

This patch simply corrects a couple of comments in the said file to
reflect what the code actually does rather than (presumably) what the
code used to do at some time in the distant past.

In my case, I've been working on a patch for the kernel that uses
these facilities, and was getting confused because of the discrepancy
between what the comments say and what actually happens. It wasn't
until I realised that the comments were just plain wrong that I was
able to sort the thing out, so I'm submitting this patch to prevent
others having the same problem.

Incidentally, the code as it stands actually simplifies the patch I
was working on considerably, and I regard this as a useful feature as
a result.

I don't have the latest 2.4-pre kernel to hand to check, but it's
quite likely that this patch can also be applied to that with the same

Best wishes from Riley.

* Copyright (C) 2000, Memory Alpha Systems.
* All rights and wrongs reserved.

| There is something frustrating about the quality and speed of Linux |
| development, ie., the quality is too high and the speed is too high, |
| in other words, I can implement this XXXX feature, but I bet someone |
| else has already done so and is just about to release their patch. |
--- linux-2.2.17/kernel/printk.c~ Wed Oct 27 01:53:42 1999
+++ linux-2.2.17/kernel/printk.c Sat Oct 28 10:01:20 2000
@@ -109,12 +109,12 @@
* Commands to do_syslog:
* 0 -- Close the log. Currently a NOP.
* 1 -- Open the log. Currently a NOP.
* 2 -- Read from the log.
- * 3 -- Read up to the last 4k of messages in the ring buffer.
+ * 3 -- Read all messages remaining in the ring buffer.
- * 4 -- Read and clear last 4k of messages in the ring buffer
+ * 4 -- Read and clear all messages remaining in the ring buffer
* 5 -- Clear ring buffer.
* 6 -- Disable printk's to console
* 7 -- Enable printk's to console
* 8 -- Set level of messages printed to console
 \ /
  Last update: 2005-03-22 12:45    [W:0.102 / U:0.040 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site