Messages in this thread |  | | Subject | Re: [PROPOSED PATCH] ATM refcount + firestream | Date | Fri, 27 Oct 2000 16:56:11 +0200 (MEST) | From | (Rogier Wolff) |
| |
Brian Gerst wrote: > > > + struct module *owner; > > > + struct module *owner; > > > bix:/home/morton> > > > > We use it throught the fops_get/fops_put macros to in/decrease the mod > > counter. See the definitions for those macros (include/linux/fs.h) > > > > Patrick > > This will break horribly if fops_put/get are changed to inlines instead > of macros. They are only supposed to be used on struct file_operations.
Oh?
Anyway, we'll get nice warnings about wrong type of argument when that happens.
I was the one who found the fops_get/put code useful as a guideline and also in fact as the code to call.
So the question is: What is the defined interface for fops_get/put: Is it "it's a macro that... " or is it "it's a function (possibly a macro for efficiency) that.... "?
Roger.
P.S. Apologies for Patrick's bad quoting habits: He had to catch a train and forgot to delete the rest of the quoted mail.
-- ** R.E.Wolff@BitWizard.nl ** http://www.BitWizard.nl/ ** +31-15-2137555 ** *-- BitWizard writes Linux device drivers for any device you may have! --* * Common sense is the collection of * ****** prejudices acquired by age eighteen. -- Albert Einstein ******** - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org Please read the FAQ at http://www.tux.org/lkml/
|  |