Messages in this thread |  | | Date | Fri, 27 Oct 2000 10:49:12 -0400 | From | Brian Gerst <> | Subject | Re: [PROPOSED PATCH] ATM refcount + firestream |
| |
Patrick van de Lageweg wrote: > > On Fri, 27 Oct 2000, Andrew Morton wrote: > > > Patrick van de Lageweg wrote: > > > > > > Hi all, > > > > > > Here is the second try for the atm refcount problem. I've made made > > > several enhancement over the previos patch. Can you take a look at it if > > > I've missed anything? (This time it also includes the driver for the > > > firestream card. That's why the patch is so large. It's gziped and > > > uuencoded). > > > > Patrick, I looked at the modules stuff and you do not > > appear to be actually _using_ it anywhere: > > > > bix:/home/morton> grep owner patch > > + owner: THIS_MODULE, > > + owner: THIS_MODULE > > + owner: THIS_MODULE, > > + owner: THIS_MODULE, > > + owner: THIS_MODULE, > > + owner: THIS_MODULE, > > + owner: THIS_MODULE, > > + struct module *owner; > > + struct module *owner; > > bix:/home/morton> > > We use it throught the fops_get/fops_put macros to in/decrease the mod > counter. See the definitions for those macros (include/linux/fs.h) > > Patrick
This will break horribly if fops_put/get are changed to inlines instead of macros. They are only supposed to be used on struct file_operations.
--
Brian Gerst - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org Please read the FAQ at http://www.tux.org/lkml/
|  |