lkml.org 
[lkml]   [2000]   [Oct]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: missing mxcsr initialization
Andrea Arcangeli wrote:
>
> On Wed, Oct 25, 2000 at 02:46:19PM -0400, Doug Ledford wrote:
> > @@ -214,8 +215,8 @@
> > movb ready,%al # First CPU if 0
> > orb %al,%al
> > jz 4f # First CPU skip this stuff
> > - movl %cr4,%eax # Turn on 4Mb pages
> > - orl $16,%eax
> > + movl %cr4,%eax # Set CR4 register to match first CPU
> > + orl X86_MMU_CR4,%eax
> > movl %eax,%cr4
> > movl %cr3,%eax # Intel specification clarification says
> > movl %eax,%cr3 # to do this. Maybe it makes a difference.
>
> I had a fast look and I don't see why you do that change. Infact
> I think this whole section could be removed:
>
> movl %cr4,%eax # Turn on 4Mb pages
> orl $16,%eax
> movl %eax,%cr4
>
> We just reload the cr4 at the very early part of the boot stage.

I thought the same thing while reviewing this code, but I didn't have time to
test the change so I didn't want to do so just yet. I was being safe...

--

Doug Ledford <dledford@redhat.com> http://people.redhat.com/dledford
Please check my web site for aic7xxx updates/answers before
e-mailing me about problems
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 12:45    [W:0.108 / U:0.440 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site