lkml.org 
[lkml]   [2000]   [Oct]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: 2.4.0-test9-pre8
On Mon, Oct 02, 2000 at 10:26:20AM -0500, Jeff Garzik wrote:
> On Mon, 2 Oct 2000, David Weinehall wrote:
>
> > Warnings on build with v2.4.0test9pre8 (with Rik van Riel's extra fixes):
> >
> > parport_pc.c:2283: warning: `parport_pc_superio_info' defined but not used
>
> .config dependent I think.

Yes, as I said, I don't use PCI. That struct is only used by PCI-stuff.
Actually, most of the code in that file is.

> > sg.c: In function `exit_sg':
> > sg.c:1321: warning: implicit declaration of function `sg_proc_cleanup'
>
> This is definitely wrong...

Uhm. Probably, I just had a brief look at it. Still, sg_proc_cleanup is
only defined when MODULE is defined, so something else is broken if this
patch is incorrect. There are quite a lot of #ifdef MODULE in that file.

> --- linux-2.4.0test9pre8rielvmpatch/drivers/scsi/sg.c.old Mon Oct 2
> 17:11:11 2000
> +++ linux-2.4.0test9pre8rielvmpatch/drivers/scsi/sg.c Mon Oct 2 17:12:18
> 2000
> @@ -1318,7 +1318,9 @@
> static void __exit exit_sg( void)
> {
> #ifdef CONFIG_PROC_FS
> +#ifdef MODULE
> sg_proc_cleanup();
> +#endif /* MODULE */
> #endif /* CONFIG_PROC_FS */
> scsi_unregister_module(MODULE_SCSI_DEV, &sg_template);
> devfs_unregister_chrdev(SCSI_GENERIC_MAJOR, "sg");


/David
_ _
// David Weinehall <tao@acc.umu.se> /> Northern lights wander \\
// Project MCA Linux hacker // Dance across the winter sky //
\> http://www.acc.umu.se/~tao/ </ Full colour fire </
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 12:39    [W:0.177 / U:3.792 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site