[lkml]   [2000]   [Oct]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH] Make agpsupport work with modversions

On Wed, 18 Oct 2000, John Levon wrote:
> I have only compile-tested the patch below with 2.4.0test10pre3 and
> 2.2.18pre16 (some fuzz on apply). Hope it's right, I can't test if it
> fixes the MODVERSIONS+in kernel agp+in kernel drm case. I tested kernel
> and module cases.

It looks better.

However, the fact that you need that dependency on CONFIG_MODULES _still_
shows that something is wrong. That dependency should not be there, and
the drm code should be fixed. Why does it care about CONFIG_MODULES at
all? It should not, and it _must_ not do that.

I have no idea what the get_module_symbol() code in question is trying to
do, but this should be _fixed_ and not just worked around. That's a bug.


To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to
Please read the FAQ at

 \ /
  Last update: 2005-03-22 12:41    [W:0.075 / U:8.928 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site