[lkml]   [2000]   [Oct]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH] Make agpsupport work with modversions
On Wed, 18 Oct 2000, Linus Torvalds wrote:

> It looks better.
> However, the fact that you need that dependency on CONFIG_MODULES _still_
> shows that something is wrong. That dependency should not be there, and
> the drm code should be fixed. Why does it care about CONFIG_MODULES at
> all? It should not, and it _must_ not do that.
> I have no idea what the get_module_symbol() code in question is trying to
> do, but this should be _fixed_ and not just worked around. That's a bug.
> Linus

For some reason this code is there to allow agp to be a module when drm is
built into the kernel. I don't know why - the maintainers should comment
on this one ...

It is because of get_module_symbol() in the first place (of course a
no-op without CONFIG_MODULES). I can't see a reason for this routine to
exist *at all* really.

The only other users are 8390.h and a couple of mtd things. I don't see
why this stuff cannot be handled in userspace with /etc/modules.conf ...

should get_module_symbol() die ?


"Mathemeticians stand on each other's shoulders while computer scientists
stand on each other's toes."
- Richard Hamming

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to
Please read the FAQ at

 \ /
  Last update: 2005-03-22 12:41    [W:0.128 / U:7.672 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site