lkml.org 
[lkml]   [2000]   [Oct]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: BLKSSZGET change will break fdisk
On Mon, Oct 16, 2000 at 08:04:27PM +0200, Roman Zippel wrote:

> I noticed that behaviour of BLKSSZGET changed between 2.2 and 2.4. One of
> the users will be fdisk, as soon as it is compiled with 2.4 kernel
> headers, but then fdisk will be no longer usable under 2.2!
> My question now is, wouldn't it be better to use a new ioctl (like
> BLKHSSZGET) and keep the old behaviour of BLKSSZGET?

No, BLKSSZGET has only a single purpose, and it is right in 2.4
and wrong in 2.2. Maybe I should send Alan a BLKSSZGET patch.
We already agreed in email that it was wrong, but then
did not do anything about it.

Concerning fdisk, luckily you are mistaken - its source says

#if defined(BLKSSZGET) && defined(HAVE_blkpg_h)

so that it will not use the broken BLKSSZGET of 2.2.

[now that you make me look at this, there is a flaw in fdisk there;
fixed in 2.10p]

Andries
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 12:41    [W:0.033 / U:0.084 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site