Messages in this thread |  | | Date | Mon, 16 Oct 2000 17:31:47 -0400 | From | Jeff Garzik <> | Subject | Re: PATCH 2.4.0.10.3: pc_keyb and q40_keyb cleanup |
| |
Andrea Arcangeli wrote: > > On Sun, Oct 15, 2000 at 03:48:55PM -0400, Jeff Garzik wrote: > > Changes: > > * both: we know we are in an interrupt, so > > s/spin_lock_irqsave/spin_lock/ > > There request_irq is not called passing the SA_INTERRUPT flag so the irq > handler is recalled with irqs enabled and in turn irqsave is necessary.
hmmm. Can you elaborate on this a bit?
I didn't know that bit about !SA_INTERRUPT, but why is irqsave necessary in these drivers? I don't see handle_kbd_event() being called from a timer or anything special like that..
-- Jeff Garzik | The difference between laziness and Building 1024 | prioritization is the end result. MandrakeSoft | - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org Please read the FAQ at http://www.tux.org/lkml/
|  |