Messages in this thread |  | | Date | Sun, 15 Oct 2000 22:57:00 +0100 (BST) | From | Tigran Aivazian <> | Subject | Re: [2.4.0test10-pre3]drm_proc_init incorrect when multiple device are registering |
| |
just to add one more detail -- your comparison with /proc/irq is superficial, i.e. only looks the same on the surface but not when you look in depth. The case with /proc/irq was a bug whilst here we have a design that dictates this behavior (but can possibly be worked around)
On Sun, 15 Oct 2000, Tigran Aivazian wrote:
> Hi David, > > Yes, this is a well-known problem and was briefly discussed between Rick > Faith, Al Viro and myself. The thing is that DRI design dictates > duplication of the code instead of sharing it between individual low-level > drivers (this is not silly -- there are lots of valid reasons for this as > was explained to me by Rick Faith) and this makes it rather clumsy to > share a common /proc entry as you can see from a little hack there which > used to work some time ago. > > So, one either needs to enhance the hack to work today (Rick's suggestion) > or to write a "drmfs" (Al Viro's suggestion) or to abandon the original > design of not-sharing the code and do share it (my suggestion but of > course it's up to Rick and other maintainers of that code -- they know > better how to make their own life easier). > > Regards, > Tigran > > On Mon, 16 Oct 2000, FORT David wrote: > > > Hi, > > I've just got a look at file drivers/char/drm/proc.c, correct me if i'm > > wrong but > > when registering using "drm_proc_init" each device supporting drm > > duplicates the dri dir entry, as "create_proc_entry " blindly create a > > new dri entry even if one already exists. > > > > IIRC a few month ago the same kind of error was occuring in /proc/irq, > > perhaps we should check in > > create_proc_entry that an entry exists before creating it, this could > > prevent each driver from doing this > > job. > > > > -- > > %--IRIN->-Institut-de-Recherche-en-Informatique-de-Nantes-----------------% > > % FORT David, % > > % 7 avenue de la morvandière 0240726275 % > > % 44470 Thouare, France epopo@onetelnet.fr % > > % ICU:78064991 AIM: enlighted popo fort@irin.univ-nantes.fr % > > %--LINUX-HTTPD-PIOGENE----------------------------------------------------% > > % -datamining <-/ | .~. % > > % -networking/flashed PHP3 coming soon | /V\ L I N U X % > > % -opensource | // \\ >Fear the Penguin< % > > % -GNOME/enlightenment/GIMP | /( )\ % > > % feel enlighted.... | ^^-^^ % > > % http://ibonneace.dnsalias.org/ when connected % > > %-------------------------------------------------------------------------% > > > > > > > >
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org Please read the FAQ at http://www.tux.org/lkml/
|  |