lkml.org 
[lkml]   [2000]   [Oct]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
Subject[PATCH] RTL 8139 oops cured
Hi!

Instead of checking all possible error bits, the RxStatusOK bit should be
checked. I encounter rx_status==0 when I stress my P90, which gives a
negative packet size (-4), and an oops in eth_copy_and_sum.

Applies to 2.4.0-test10-pre2...

/Tobias

--- 8139too.c.orig Sun Oct 15 01:49:47 2000
+++ 8139too.c Sun Oct 15 03:22:46 2000
@@ -1736,8 +1736,7 @@
/* if Rx err received, Rx process gets reset, so
* we abort any further Rx processing
*/
- if (rx_status &
- (RxBadSymbol | RxRunt | RxTooLong | RxCRCErr | RxBadAlign)) {
+ if (!(rx_status & RxStatusOK)) {
rtl8139_rx_err (rx_status, dev, tp, ioaddr);
return;
}
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 12:41    [W:0.067 / U:0.836 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site