lkml.org 
[lkml]   [2000]   [Oct]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] Fix SCSI proc oops
   Date: Fri, 13 Oct 2000 20:37:46 -0700 (PDT)
From: Linus Torvalds <torvalds@transmeta.com>

Why would it crash the sparc?

If it wasn't there originally, the loop will not find it, and the
loop will be a no-op.

The loop would be a no-op but the remove_proc_entry call would not.
Perhaps you didn't notice that there too? It's pretty close to the
loop :-)

tpnt->proc_name in this case is NULL, that is fed to the procfs
unregister code (and next to strncmp), leading to an OOPS on non-x86
during bootup with scsi adapter drivers not in the machine compiled
statically into the kernel.

This is why it would crash on sparc.

Explain.

Just let me know which part of the above is hard to understand and
I'll try my best to clear things up. Thanks.

Later,
David S. Miller
davem@redhat.com
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 12:41    [W:0.119 / U:2.580 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site