lkml.org 
[lkml]   [2000]   [Oct]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [RFC] atomic pte updates and pae changes, take 2
Hi,

On Fri, Oct 13, 2000 at 08:17:42PM -0400, Ben LaHaise wrote:
>
> Below is take two of the patch making pte_clear use atomic xchg in an
> effort to avoid the loss of dirty bits. PAE no longer uses cmpxchg8 for
> updates; set_pte is two ordered long writes with a barrier.

Looks good. The only trouble I can see left is that pte_clear() is
still using set_pte(), which doesn't work right for PAE36. set_pte()
is setting the high word first, which is fine for installing a new pte,
but if you do that to clear a pte then you have left the old
page-present bit intact while you've removed have of the pte.
pte_clear() needs to clear the words in the other order (just as
pte_get_and_clear correctly does).

Cheers,
Stephen
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 12:41    [W:0.056 / U:0.240 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site