lkml.org 
[lkml]   [2000]   [Oct]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] Fix SCSI proc oops
On Sat, Oct 14 2000, David S. Miller wrote:
> Date: Fri, 13 Oct 2000 20:37:46 -0700 (PDT)
> From: Linus Torvalds <torvalds@transmeta.com>
>
> Why would it crash the sparc?
>
> If it wasn't there originally, the loop will not find it, and the
> loop will be a no-op.
>
> The loop would be a no-op but the remove_proc_entry call would not.
> Perhaps you didn't notice that there too? It's pretty close to the
> loop :-)
>
> tpnt->proc_name in this case is NULL, that is fed to the procfs
> unregister code (and next to strncmp), leading to an OOPS on non-x86
> during bootup with scsi adapter drivers not in the machine compiled
> statically into the kernel.
>

David, why is tpnt->proc_name NULL on sparc for devices not existing?
Every driver has this as part of their tpnt struct, so it doesn't
matter if the underlying device really exists.


--
Torben Mathiasen <tmm@kernel.dk>
Linux ThunderLAN maintainer
http://tlan.kernel.dk
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 12:41    [W:0.120 / U:0.304 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site