lkml.org 
[lkml]   [2000]   [Oct]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] Fix SCSI proc oops


On Thu, 12 Oct 2000, Torben Mathiasen wrote:
>
> Attached patch should fix the oops's people have been getting
> while using /proc/scsi.

This patch makes no sense. Why

if (!present)
when that is obviously the wrong way around.

I'm sure it fixes an oops - I just want to understand why the test is the
wrong way around, and why this patch is as it is. I have this suspicion
that you're hiding the real bug which would be to do this in another place
completely.

Linus

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 12:41    [from the cache]
©2003-2011 Jasper Spaans