lkml.org 
[lkml]   [2000]   [Oct]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: vgaconsole driver SMP safe fix against linux-2.4.0-test9
Yong Chi wrote:
>
> My first contribution to kernel =) Someone please look over this one
> carefully =)

That's a good patch.

It is "obviously correct", it saves seven calls to __global_cli() for
each \n-terminated write to the console and it fixes the
death-with-dual-deadlock problem which Mister Owens has been complaining
about.

James has just posted a big patch against this code, so you should
coordinate this with him.

One point: you should have included linux/spinlock.h rather than
asm/spinlock.h. Obviously someone is already including this file, so
you can simply remove the #include altogether.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 12:39    [W:0.042 / U:1.348 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site