lkml.org 
[lkml]   [2000]   [Oct]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: new 3dfx framebuffer driver released
   From: Kesmarki Attila <danthe@medex.hu>
Date: Wed, 11 Oct 2000 02:02:24 +0200

A made my latest release as a patch for 2.4.0-test9. It can be
downloaded from http://www.medex.hu/~danthe/tdfx. I won't attach
it, because it's too long.

One bug spotted, in tdfxfb_probe():

+ info->bufbase_virt =
+ ioremap_nocache(info->bufbase_phys, info->bufbase_size);
+
+ if (!info->regbase_virt) {
+ printk("fb: Can't remap %s framebuffer.\n", name);
+ iounmap(info->regbase_virt);
+ goto err3;
+ }

Looks like a cut&paste error, you need to check info->bufbase_virt
against NULL, not info->regbase_virt ;-)

Later,
David S. Miller
davem@redhat.com
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 12:39    [W:0.047 / U:0.952 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site