Messages in this thread | | | Date | Mon, 31 Jan 2000 09:55:20 -0800 (PST) | From | Linus Torvalds <> | Subject | Re: [linux-usb] __initcall diff, version 2 |
| |
On Sun, 30 Jan 2000, Randy Dunlap wrote: > > I like the idea of this __initcall patch for USB. > However, I've searched other 2.3.4x drivers and found > very little use of __initcall.
It's fairly new. I heartily encourage initcalls, they are _much_ nicer than explicit initialization. The explicit way only makes sense for (a) old drivers and (b) code that requires certain ordering.
However, instead of using "__initcall" directly, I would suggest using "module_init()" and "module_exit()". Which will do the right things for drivers whether that driver is compiled as a module or not (basically, a good driver these days should have NO code that is inside #ifdef MODULE any more).
Linus
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.rutgers.edu Please read the FAQ at http://www.tux.org/lkml/
| |