Messages in this thread | | | Date | Fri, 17 Sep 1999 10:42:39 +0200 (METDST) | From | Richard Guenther <> | Subject | Re: Linux 2.3.18ac5 |
| |
On Fri, 17 Sep 1999, Jeff Garzik wrote:
> Richard Guenther wrote: > > Caveats: you dont have control over MODULE_NAME - it gets > > created out of the source file name. > > That's not very friendly... instead of messing with the kernel compile > flags, why not do this: > > #ifndef MODULE_NAME > #define MODULE_NAME __FILE__ > #endif
Because MODULE_NAME then gets foobar.c !? which is not a usable/suitable prefix either? (The Makefile would create foobar_ as prefix) Or because you have to do it _before_ the #include of the module.h header, which is messy and error-prone? Hey, I really did think before I started modifying the makefile. And - the filename is not such a bad choice either in most cases. And the biggest advantage is that it works without changing any driver source.
Richard.
-- Richard Guenther <richard.guenther@student.uni-tuebingen.de> PGP: 2E829319 - 2F 83 FC 93 E9 E4 19 E2 93 7A 32 42 45 37 23 57 WWW: http://www.anatom.uni-tuebingen.de/~richi/
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.rutgers.edu Please read the FAQ at http://www.tux.org/lkml/
| |