Messages in this thread | | | Subject | Re: PATCH: Update for the serial driver. | Date | Wed, 1 Sep 1999 10:19:23 +0200 (MEST) | From | (Rogier Wolff) |
| |
tytso@mit.edu wrote:
Hi,
Re: +#ifdef DECLARE_WAITQUEUE DECLARE_WAITQUEUE(wait, current); +#else + struct wait_queue wait = { current, NULL }; +#endif
Instead of this "kludge" every time you want to declare a waitq, I recommend putting this at the top:
#ifndef DECLARE_WAITQUEUE #define DECLARE_WAITQUEUE(wait, current) \ struct wait_queue wait = { current, NULL } #endif
That way you have as little as possible "ifdefs" in the main code. You've already done that with ALPHA_KLUDGE_MCR, which is good.
Roger.
-- ** R.E.Wolff@BitWizard.nl ** http://www.BitWizard.nl/ ** +31-15-2137555 ** *-- BitWizard writes Linux device drivers for any device you may have! --* ------ Microsoft SELLS you Windows, Linux GIVES you the whole house ------
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.rutgers.edu Please read the FAQ at http://www.tux.org/lkml/
| |