Messages in this thread | | | Date | Thu, 26 Aug 1999 03:13:05 -0700 | From | "David S. Miller" <> | Subject | Re: small patch for do_wp_page |
| |
Date: Thu, 26 Aug 1999 10:12:07 +0100 From: Philip Blundell <pb@nexus.co.uk>
>The case where you have removed the flush is not always the >ZERO_PAGE,
Hmm, really? Maybe I am misunderstanding what the "if (from == ZERO_PAGE(to))" check actually does.
You understand it just fine, however you believe that copy_cow_page is actually passed ZERO_PAGE in the instance where you removed the flush. Your change is to remove the flush from this stretch of code:
linux/mm/memory.c:~line 823
copy_cow_page(old_page,new_page); flush_page_to_ram(old_page); flush_page_to_ram(new_page);
What is the invariant which makes you believe that "old_page == ZERO_PAGE(new_page)" at this spot each and every time?
Later, David S. Miller davem@redhat.com
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.rutgers.edu Please read the FAQ at http://www.tux.org/lkml/
| |