lkml.org 
[lkml]   [1999]   [Aug]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: New resources - pls, explain :-(
Count me as one more voice for having readl_ns etc...

I added this for PCMCIA a long time ago because it was the most concise
way to handle the big/little-endian issue for my drivers. Defining
big-endian variants for read*/write* calls clearly provides equivalent
functionality, of course... so it is just a syntax issue...

> #ifdef BIG_ENDIAN
> #define gfx_readl(x) bigendian_readl(x)
> #define gfx_writel(x,y) bigendian_writel(x,y)
> #else
> #define gfx_readl(x) readl(x)
> #define gfx_writel(x,y) writel(x,y)
> #endif

So you're saying that the driver actually wants *_ns calls (since
that's what you're #defining here). If the main use of bigendian_*
calls is to create macros for the *_ns calls that drivers need, why
not just give them these calls in the first place?

-- Dave Hinds

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 13:53    [W:0.035 / U:39.932 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site