lkml.org 
[lkml]   [1999]   [Jul]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: Patch to implement getattr [patch]
From
Date
> 1. Having getattr is nice, but I'ld rather turned the old code into
> generic_getattr() and let the filesystems refer to it.

Do you mean that implementation of the getattr operation should be
mandatory, or do you mean that generic_getattr shold be called when
getattr is not implemented, like in my patch, and that generic_getattr
should be provided as a convenience function?

> 2. I think that having a wrapper around the thing (vfs_getattr()) would be
> the right thing. Just look how arch/*/* stuff does stat() emulation for
> personalities with different struct stat layout. set_fs();sys_stat();set_fs();
> and then reshuffle the stuff...<shudder>

I cannot find any stat emulation in arch/*/*. Do you have specific
examples?

/Magnus

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 13:52    [W:0.049 / U:1.708 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site