lkml.org 
[lkml]   [1999]   [Jun]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [patch] 2.3.8+ UP masq
: > This patch gets rid of numerous undefined lock problems.  Since the locks have
: > now been surrounded in ifdef SMP declarations it made sense to do the same with
: > all the locks that were used in the code.
:
: Wouldn't it be easier just to remove the #ifdef / #endif from around the lock
: declaration in the first place? On UP, they won't take up an space and the
: spin_lock() calls are optimized away. It would make the code a lot tidier.

Oh, I don't deny that but it got recently introduced in 2.3.8 and I figured
there had to be a reason for it. It was pretty late at night when I did this so
never asked if there was a reasoning behind it - why were they suddenly put in?

--
Matthew Harrell I love defenseless animals,
Simulation Technology Division, SAIC especially in a good gravy.
mharrell@sito.saic.com

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 13:52    [W:0.060 / U:0.328 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site